Matthias Clasen [Sun, 12 Jul 2020 16:14:32 +0000 (12:14 -0400)]
filechooserdialog: Stop using ::response-requested
Replace the ::response-requested signal by an action.
Matthias Clasen [Sun, 12 Jul 2020 14:34:27 +0000 (10:34 -0400)]
filechooserdialog: Stop using the embed interface
Just call private GtkFileChooserWidget api. There
is no real justification for diverting this through
an extra interface.
Matthias Clasen [Sun, 12 Jul 2020 14:26:34 +0000 (10:26 -0400)]
Remove unused includes
Only GtkFileChooserWidget and GtkFileChooserDialog
use the GtkFileChooserEmbed interface.
Matthias Clasen [Sun, 12 Jul 2020 14:20:52 +0000 (10:20 -0400)]
filechooserwidget: Use dropdown api better
We now have GtkStringList, so we can implement
the choice api a little cleaner with it.
Matthias Clasen [Sun, 12 Jul 2020 14:05:57 +0000 (10:05 -0400)]
filechooserwidget: Remove homegrown profiling
We have sysprof support now, so we no longer have
to use this homegrown profiler.
Matthias Clasen [Sun, 12 Jul 2020 14:41:01 +0000 (14:41 +0000)]
Merge branch 'drop-file-system' into 'master'
Drop file system
See merge request GNOME/gtk!2229
Matthias Clasen [Sun, 12 Jul 2020 13:58:30 +0000 (13:58 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
gtk-demo: Make style apply in the file browser
See merge request GNOME/gtk!2230
Matthias Clasen [Sun, 12 Jul 2020 03:24:10 +0000 (23:24 -0400)]
Drop GtkFileSystem
It is no longer used.
Matthias Clasen [Sun, 12 Jul 2020 03:17:40 +0000 (23:17 -0400)]
filechooserwidget: Stop using GtkFileSystem
Just use gio directly.
Matthias Clasen [Sun, 12 Jul 2020 01:42:16 +0000 (21:42 -0400)]
filechooser: Drop get_file_system from the interface
This is no longer used.
Matthias Clasen [Sun, 12 Jul 2020 01:40:06 +0000 (21:40 -0400)]
filechooserbutton: Stop using GtkFileSystem
Just use gio directly.
Matthias Clasen [Sat, 11 Jul 2020 22:11:32 +0000 (18:11 -0400)]
Reduce includes of gtkfilesystem.h
Move a few non-filesystem helpers to gtkfileutils.h,
and drop the include in all the places where it isn't needed.
Matthias Clasen [Sat, 11 Jul 2020 21:59:36 +0000 (17:59 -0400)]
pathbar: Stop using GtkFileSystem
This is just a thin wrapper around some gio functionality
these days, and we want to get rid of it.
Matthias Clasen [Sun, 12 Jul 2020 12:06:28 +0000 (08:06 -0400)]
gtk-demo: Make style apply in the file browser
Commit
5afe6f7825e1e5 claims to make this demo
'look good', but it failed to actually make its
css apply. Now it really looks good.
Matthias Clasen [Sat, 11 Jul 2020 21:23:55 +0000 (17:23 -0400)]
pathbar: Drop the Private struct
Matthias Clasen [Fri, 10 Jul 2020 19:29:18 +0000 (19:29 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Fix the build with clang
See merge request GNOME/gtk!2225
Matthias Clasen [Fri, 10 Jul 2020 15:55:46 +0000 (11:55 -0400)]
Fix the build with clang
clang doesn't allow G_GNUC_FALLBACK in dead code.
Seems silly, but what can we do.
Emmanuele Bassi [Fri, 10 Jul 2020 17:01:56 +0000 (17:01 +0000)]
Merge branch 'ebassi/ci-timeout' into 'master'
Ebassi/ci timeout
See merge request GNOME/gtk!2223
Matthias Clasen [Fri, 10 Jul 2020 16:13:48 +0000 (16:13 +0000)]
Merge branch 'ci-tweaks' into 'master'
ci: Use lsan again
See merge request GNOME/gtk!2224
Emmanuele Bassi [Fri, 10 Jul 2020 15:32:15 +0000 (16:32 +0100)]
build: Restructure the tests to use dictionaries
Instead of an array of arrays, let's use an array of dictionaries; it's
easier to add optional keys without requiring to remember where to put
empty arrays.
Emmanuele Bassi [Fri, 10 Jul 2020 15:16:15 +0000 (16:16 +0100)]
Add the filtermodel-exhaustive test to the slow suite
This increases the default timeout.
Emmanuele Bassi [Fri, 10 Jul 2020 15:12:25 +0000 (16:12 +0100)]
Increase the default timeout for slow tests
If a test is part of the 'slow' test suite, we should increment the
default timeout to compensate.
Matthias Clasen [Fri, 10 Jul 2020 15:11:42 +0000 (11:11 -0400)]
ci: Use lsan again
Turning it off didn't fix the crashes; and we allow
the asan build to fail anyway now. And the leak reports
are useful whenever it doesn't crash.
Emmanuele Bassi [Fri, 10 Jul 2020 15:08:59 +0000 (16:08 +0100)]
ci: Increase the timeout multiplier
We do have some slow tests.
Emmanuele Bassi [Fri, 10 Jul 2020 15:08:14 +0000 (16:08 +0100)]
ci: Use the timeout multiplier from the environment
When running our test suite on our CI infrastructure.
Matthias Clasen [Fri, 10 Jul 2020 13:04:34 +0000 (13:04 +0000)]
Merge branch 'asan-ci' into 'master'
Asan ci
See merge request GNOME/gtk!2214
Matthias Clasen [Fri, 10 Jul 2020 11:32:48 +0000 (07:32 -0400)]
Disable lsan for now
The leak sanitizer causes on average 3-4 tests
to segfault during a testsuite run. Disable it
for now to see if we can get a successful
testsuite run with asan alone.
Matthias Clasen [Thu, 9 Jul 2020 23:53:25 +0000 (23:53 +0000)]
Merge branch 'wip/Jehan/gio-querymodules-pkg-config-master' into 'master'
build-aux: search various Glib/GIO utilities in .pc file.
See merge request GNOME/gtk!2129
Matthias Clasen [Thu, 9 Jul 2020 02:22:31 +0000 (22:22 -0400)]
ci: Add a build with asan
Run our testsuite under asan. We do this in a
separate build, since we need to turn off
introspection to make the build succeed.
As Michael Catanzaro pointed out, this requires a
privileged runner in order to use kernel apis.
Matthias Clasen [Thu, 9 Jul 2020 23:06:37 +0000 (23:06 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
x11: Plug a memory leak
See merge request GNOME/gtk!2222
Matthias Clasen [Thu, 9 Jul 2020 17:52:53 +0000 (13:52 -0400)]
x11: Plug a memory leak
Don't leak atoms when we're storing the clipboard.
Benjamin Otte [Thu, 9 Jul 2020 21:34:02 +0000 (21:34 +0000)]
Merge branch 'wip/otte/for-master' into 'master'
Wip/otte/for master
See merge request GNOME/gtk!2221
Benjamin Otte [Tue, 7 Jul 2020 17:02:29 +0000 (19:02 +0200)]
sorter: Remove a return_if_fail()
It's too expsensive.
Benjamin Otte [Thu, 9 Jul 2020 20:26:57 +0000 (22:26 +0200)]
testsuite: Be more exhaustive
Create larger source models in tests, so that we hit the incremental
batch size more often and have a higher chance to expose bugs there.
Benjamin Otte [Thu, 9 Jul 2020 20:22:04 +0000 (22:22 +0200)]
filterlistmodel: Don't filter out every 513th element
Incremental filtering would skip every 513th element due to an
off-by-one error.
Test included
Matthias Clasen [Thu, 9 Jul 2020 17:55:02 +0000 (13:55 -0400)]
Ignore more leaks in asan
These showed up in ci. The atk-bridge will
be gone before too long anyway. Since we
may not have debug symbols in ci, just at
the so's.
Matthias Clasen [Thu, 9 Jul 2020 20:05:07 +0000 (20:05 +0000)]
Merge branch 'wip/carlosg/range-autoscroll' into 'master'
gtkrange: group gestures the right way around
See merge request GNOME/gtk!2220
Matthias Clasen [Thu, 9 Jul 2020 02:19:32 +0000 (22:19 -0400)]
ci: Set LSAN_OPTIONS for tests
When running the testsuite with the address sanitizer,
many of our dependencies cause it to report cause it
to report memory leaks, causing tests to fail.
Therefore, point the leak sanitizer at a list of
suppressions. The list is kept in the lsan.supp
file in git.
Matthias Clasen [Thu, 9 Jul 2020 02:18:45 +0000 (22:18 -0400)]
ci: Use the fedora:v20 image
This image includes libasan and libubsan.
Matthias Clasen [Thu, 9 Jul 2020 17:11:26 +0000 (13:11 -0400)]
ci: Mention image layering in the README
Matthias Clasen [Thu, 9 Jul 2020 02:17:26 +0000 (22:17 -0400)]
ci: Add libasan and libubsan to the image
Add libasan and libubsan to fedora-base:v20,
and build fedora:20 on top of it.
This is so we can build and run the tests with
the address and undefined behavior sanitizers.
Carlos Garnacho [Thu, 9 Jul 2020 18:44:42 +0000 (20:44 +0200)]
gtkrange: group gestures the right way around
The gtk_gesture_group() call is not a commutative operation, it
takes two gestures, maybe detaches the first one from its current
group, and adds it to the same group than the second gesture.
With the flipped argument order here, GtkRange was actually detaching
the same gesture in order to group it with a second one two times, so
the desired effect to group all 3 gestures was not achieved.
Fixes autoscroll as the drag gesture is now actually grouped with the
click one, so drag offsets can be accessed from the autoscroll
timeout.
Matthias Clasen [Thu, 9 Jul 2020 17:52:53 +0000 (13:52 -0400)]
x11: Plug a memory leak
Don't leak atoms when we're storing the clipboard.
Matthias Clasen [Thu, 9 Jul 2020 17:19:57 +0000 (17:19 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
css: Plug a memory leak
Closes #2921
See merge request GNOME/gtk!2219
Matthias Clasen [Thu, 9 Jul 2020 16:14:18 +0000 (12:14 -0400)]
css: Plug a memory leak
When a rule has no styles, we don't add it
to our ruleset. Since we are not adopting
the selectors in this case, we must free them.
Fixes: #2921
Matthias Clasen [Thu, 9 Jul 2020 15:56:13 +0000 (15:56 +0000)]
Merge branch 'wip/carlosg/scrollbar-fixes' into 'master'
Scrollbar fixes
Closes #2879
See merge request GNOME/gtk!2216
Carlos Garnacho [Thu, 9 Jul 2020 14:53:47 +0000 (16:53 +0200)]
gdk/x11: Ignore regular crossing events while in implicit grabs
If we create an implicit grab on a surface, leave the surface, and
release the button, we would get 2 XI_Leave events, one with mode
XINotifyNormal when the pointer leaves the surface, and another with
mode XINotifyUngrab when the button is released.
Meanwhile, the upper layers rely on crossing events being paired,
and particularly in no crossing event being sent until the implicit
grab is dismissed (either by releasing it, or via more pervasive
grabs).
Ignoring the set of XINotifyNormal events while an implicit grab
is active adapts the X11 backend to this behavior. If the grab were
released or taken away by another grab, a crossing event with one
of the other XINotify*Grab/XINotify*Ungrab will be generated.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/2879
Matthias Clasen [Thu, 9 Jul 2020 14:49:42 +0000 (14:49 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!2212
Matthias Clasen [Thu, 9 Jul 2020 14:39:01 +0000 (14:39 +0000)]
Merge branch 'ebassi/subprojects-depth' into 'master'
Use depth=1 for cloning sub-projects
See merge request GNOME/gtk!2215
Matthias Clasen [Thu, 9 Jul 2020 14:31:14 +0000 (14:31 +0000)]
Merge branch 'file-chooser-api-cleanup-2' into 'master'
File chooser api cleanup 2
See merge request GNOME/gtk!2213
Carlos Garnacho [Thu, 9 Jul 2020 14:10:55 +0000 (16:10 +0200)]
gtkscrolledwindow: Look up correctly target in captured motion events
Check correctly that the captured motion events are emitted towards the
content or one of the scrollbars, in order to have it set the expected
"over" state depending on whether the drag begins from the scrolledwindow
content or one of the scrollbars.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/2879
Matthias Clasen [Thu, 9 Jul 2020 12:20:39 +0000 (08:20 -0400)]
NEWS: Updates
Matthias Clasen [Thu, 9 Jul 2020 04:33:35 +0000 (00:33 -0400)]
Add a suppression file for asan
This can be used similar to valgrind suppressions:
LSAN_OPTIONS=suppressions=`pwd`/lsan.supp meson tests -Cbuild
Matthias Clasen [Thu, 9 Jul 2020 04:32:49 +0000 (00:32 -0400)]
tests: Plug some more memory leaks
These showed up under asan.
Matthias Clasen [Thu, 9 Jul 2020 04:31:06 +0000 (00:31 -0400)]
cups: Plug a memory leak
This showed up under asan.
Matthias Clasen [Thu, 9 Jul 2020 13:28:07 +0000 (13:28 +0000)]
Merge branch 'wayland_surface_app_id_changing' into 'master'
add a way to change the application_id of a toplevel wayland GdkSurface
See merge request GNOME/gtk!2205
Emmanuele Bassi [Thu, 9 Jul 2020 13:07:14 +0000 (14:07 +0100)]
Use depth=1 for cloning sub-projects
We don't really need the full history and branches when building
sub-projects.
This should shave some bandwidth and time in our CI pipeline as well.
Matthias Clasen [Thu, 9 Jul 2020 11:42:33 +0000 (11:42 +0000)]
Merge branch 'fix-levelbar-layout' into 'master'
levelbar: Chainup to parent buildable when handling custom tags
See merge request GNOME/gtk!2200
Matthias Clasen [Thu, 9 Jul 2020 06:06:31 +0000 (02:06 -0400)]
filechooser: Drop the ::selection-changed signal
This signal does not work on native file choosers,
and it exposes internals of the widget that should
not be public. And it is just not very interesting.
Matthias Clasen [Thu, 9 Jul 2020 05:48:33 +0000 (01:48 -0400)]
filechooser: Drop the ::current-folder-changed signal
This signal does not work on native file choosers,
and it exposes internals of the widget that should
not be public. And it is just not very interesting.
Matthias Clasen [Thu, 9 Jul 2020 05:44:09 +0000 (01:44 -0400)]
filechoosernative: Update docs
Remove mention of things that are no longer
in the filechooser api.
Matthias Clasen [Thu, 9 Jul 2020 05:40:08 +0000 (01:40 -0400)]
filechooser: Drop the ::file-activated signal
This signal does not work on native file choosers,
and it exposes internals of the widget that should
not be public. And it is just not very interesting.
Matthias Clasen [Thu, 9 Jul 2020 05:29:20 +0000 (01:29 -0400)]
filechooser: Make get_files return a list model
Like the other list getters in this interface,
make gtk_file_chooser_get_files() return a
list model.
Matthias Clasen [Thu, 9 Jul 2020 04:51:11 +0000 (00:51 -0400)]
Cosmetics
Matthias Clasen [Thu, 9 Jul 2020 04:46:55 +0000 (00:46 -0400)]
filechooser: Drop gtk_file_chooser_[un]select_file
Most use cases for these apis can be handled with
gtk_file_chooser_set_file and/or
gtk_file_chooser_set_current_folder.
Matthias Clasen [Wed, 8 Jul 2020 14:12:51 +0000 (10:12 -0400)]
filechooser: Drop gtk_file_chooser_[un]_select_all
For now, we just remove them as public api, they are
still used internally.
Matthias Clasen [Wed, 8 Jul 2020 14:12:09 +0000 (10:12 -0400)]
tests: Stop using file chooser apis that are going away
gtk_file_chooser_[un]select_all are going away, stop
using them.
Matthias Clasen [Thu, 9 Jul 2020 04:49:19 +0000 (00:49 -0400)]
docs: Add gtk_file_chooser_get_shortcut_folders
Matthias Clasen [Thu, 9 Jul 2020 04:40:34 +0000 (04:40 +0000)]
Merge branch 'printing-portal-fix-master' into 'master'
Remember to call print_cb even if print operation is cancelled.
Closes #2917
See merge request GNOME/gtk!2211
Matthias Clasen [Thu, 9 Jul 2020 04:33:35 +0000 (00:33 -0400)]
Add a suppression file for asan
This can be used similar to valgrind suppressions:
LSAN_OPTIONS=suppressions=`pwd`/lsan.supp meson tests -Cbuild
Matthias Clasen [Thu, 9 Jul 2020 04:32:49 +0000 (00:32 -0400)]
tests: Plug some more memory leaks
These showed up under asan.
Matthias Clasen [Thu, 9 Jul 2020 04:31:06 +0000 (00:31 -0400)]
cups: Plug a memory leak
This showed up under asan.
Casey Jao [Thu, 9 Jul 2020 03:31:49 +0000 (23:31 -0400)]
Remember to call print_cb even if print operation is cancelled.
Closes #2917.
Matthias Clasen [Thu, 9 Jul 2020 02:08:53 +0000 (02:08 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
directorylist: Fix file monitoring implementation
See merge request GNOME/gtk!2209
Matthias Clasen [Wed, 8 Jul 2020 21:43:14 +0000 (17:43 -0400)]
testsuite: Assorted leak fixes
All found by asan.
Matthias Clasen [Wed, 8 Jul 2020 21:42:29 +0000 (17:42 -0400)]
shortcuttrigger: Fix some leaks in error paths
Found while running the testsuite under asan.
Matthias Clasen [Wed, 8 Jul 2020 21:41:54 +0000 (17:41 -0400)]
css: Fix some memory leaks in error paths
Found while running the testsuite under asan.
Matthias Clasen [Wed, 8 Jul 2020 20:42:35 +0000 (16:42 -0400)]
picture: Don't leak alternative-test
This leak showed up while running the testsuite
under asan.
Matthias Clasen [Wed, 8 Jul 2020 20:42:01 +0000 (16:42 -0400)]
bookmarklist: Don't leak uris
This leak showed up in multiple places while
running the testsuite under asan.
Matthias Clasen [Wed, 8 Jul 2020 20:34:58 +0000 (16:34 -0400)]
testsuite: Fix a memory leak in the bitmask tests
This was showing up when running under asan.
Matthias Clasen [Wed, 8 Jul 2020 20:29:32 +0000 (16:29 -0400)]
gsk: Fix a transform leak
This was found by running our testsuite under asan.
Matthias Clasen [Wed, 8 Jul 2020 19:05:16 +0000 (15:05 -0400)]
testsuite: Fix some memory leaks reported by asan
Matthias Clasen [Wed, 8 Jul 2020 19:04:12 +0000 (15:04 -0400)]
testsuite: Fix an asan error
asan complains that some of the memorytexture tests
read past limits. Avoid that.
Matthias Clasen [Wed, 8 Jul 2020 17:41:01 +0000 (13:41 -0400)]
directorylist: Fix file monitoring implementation
The while loops were never advancing the iterator.
Oops.
Yuri Chornoivan [Wed, 8 Jul 2020 18:28:01 +0000 (18:28 +0000)]
Update Ukrainian translation
Baurzhan Muftakhidinov [Wed, 8 Jul 2020 17:44:28 +0000 (17:44 +0000)]
Update Kazakh translation
Daniel Șerbănescu [Wed, 8 Jul 2020 16:22:30 +0000 (16:22 +0000)]
Update Romanian translation
Florentina Mușat [Wed, 8 Jul 2020 16:17:12 +0000 (16:17 +0000)]
Update Romanian translation
Florentina Mușat [Wed, 8 Jul 2020 08:33:20 +0000 (08:33 +0000)]
Update Romanian translation
Matthias Clasen [Wed, 8 Jul 2020 02:25:46 +0000 (02:25 +0000)]
Merge branch 'directorylist-monitor' into 'master'
directorylist: Add monitoring
See merge request GNOME/gtk!2207
Matthias Clasen [Tue, 7 Jul 2020 22:44:41 +0000 (18:44 -0400)]
directorylist: Add monitoring
Add a GtkDirectoryList:monitored property, and
keep a file monitor if it is set to TRUE. To ensure
that the list reflects reality, we reload the directory
when monitoring is turned on after the fact. This means
that turning monitoring is expensive, while turning it
off is cheap, so we default to monitoring being on.
Jordi Mas [Tue, 7 Jul 2020 18:24:24 +0000 (20:24 +0200)]
Fixes to Catalan translations
Yuri Chornoivan [Tue, 7 Jul 2020 18:03:32 +0000 (18:03 +0000)]
Update Ukrainian translation
Yuri Chornoivan [Tue, 7 Jul 2020 17:55:52 +0000 (17:55 +0000)]
Update Ukrainian translation
Baurzhan Muftakhidinov [Tue, 7 Jul 2020 17:21:22 +0000 (17:21 +0000)]
Update Kazakh translation
Matthias Clasen [Tue, 7 Jul 2020 17:04:51 +0000 (17:04 +0000)]
Merge branch 'inspector-navigation' into 'master'
Inspector navigation
See merge request GNOME/gtk!2201
Matthias Clasen [Tue, 7 Jul 2020 06:12:30 +0000 (02:12 -0400)]
inspector: Fix property list styling
We use dropdowns here now, so style them.
Also, avoid the swoosh when switching to the
property list, when everything shrinks.
Caolán McNamara [Tue, 7 Jul 2020 14:45:30 +0000 (15:45 +0100)]
gtk#767 add a way to change the application_id of a toplevel wayland GdkSurface
so LibreOffice can reuse toplevels and get the right task icons
references;
https://gitlab.gnome.org/GNOME/gtk/-/issues/767
https://lists.freedesktop.org/archives/wayland-devel/2019-July/040704.html
https://gitlab.freedesktop.org/wayland/wayland-protocols/commit/
e0d6ad1d5e7e80321285a9b14ca3329289eb02e6
https://bugs.documentfoundation.org/show_bug.cgi?id=125934
https://bugzilla.redhat.com/show_bug.cgi?id=
1334915
https://bugreports.qt.io/browse/QTBUG-77182
Emmanuele Bassi [Tue, 7 Jul 2020 11:48:07 +0000 (11:48 +0000)]
Merge branch 'issue-2915' into 'master'
Issue 2915
Closes #2915
See merge request GNOME/gtk!2204
Emmanuele Bassi [Tue, 7 Jul 2020 11:04:13 +0000 (12:04 +0100)]
Annotate string array
Fixes: #2915